Skip to content

[LokaliseBridge] Fix push command --delete-missing options when there are no missing messages #47391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

[LokaliseBridge] Fix push command --delete-missing options when there are no missing messages #47391

merged 1 commit into from
Aug 26, 2022

Conversation

rwionczek
Copy link
Contributor

@rwionczek rwionczek commented Aug 25, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

When translation:push lokalise --delete-missing command is executed and the messages are the same locally as in Lokalise, then the command removes all messages from Lokalise. This happens because the getKeysIds method in LokaliseProvider return all key ids when receives an empty array (empty filter_keys param in request to Lokalise API).

This code prevent execution of getKeysIds method when there are no messages to delete from Lokalise.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 4.4, 5.4, 6.0, 6.1, 6.2.

Cheers!

Carsonbot

@rwionczek rwionczek force-pushed the bugfix/translation_bridge_lokalise_push_delete_missing_option branch from a14995b to 1769094 Compare August 25, 2022 22:46
@rwionczek rwionczek changed the base branch from 5.3 to 5.4 August 25, 2022 22:46
@rwionczek rwionczek force-pushed the bugfix/translation_bridge_lokalise_push_delete_missing_option branch from 1769094 to c4f651e Compare August 25, 2022 23:32
@fabpot
Copy link
Member

fabpot commented Aug 26, 2022

Thank you @rwionczek.

@fabpot fabpot merged commit c2c522a into symfony:5.4 Aug 26, 2022
This was referenced Aug 26, 2022
Merged
Merged
Merged
@fabpot fabpot mentioned this pull request Sep 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwionczek @carsonbot @fabpot