Skip to content

[HttpClient] Fix computing retry delay when using RetryableHttpClient #47441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2022
Merged

[HttpClient] Fix computing retry delay when using RetryableHttpClient #47441

merged 1 commit into from
Sep 8, 2022

Conversation

martkop26
Copy link
Contributor

@martkop26 martkop26 commented Aug 31, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47430
License MIT

@carsonbot carsonbot added this to the 6.2 milestone Aug 31, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 4.4 Aug 31, 2022
@carsonbot
Copy link

Hey!

I think @rmikalkenas has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [HttpClientBundle] Bugfix for delayed retryableHttpClient [HttpClient] [HttpClientBundle] Bugfix for delayed retryableHttpClient Sep 2, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 5.4 Sep 8, 2022
@nicolas-grekas nicolas-grekas changed the title [HttpClient] [HttpClientBundle] Bugfix for delayed retryableHttpClient [HttpClient] [HttpClientBundle] Fix computing retry delay when using RetryableHttpClient Sep 8, 2022
@nicolas-grekas nicolas-grekas changed the title [HttpClient] [HttpClientBundle] Fix computing retry delay when using RetryableHttpClient [HttpClient] Fix computing retry delay when using RetryableHttpClient Sep 8, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 5.4 September 8, 2022 09:24
@nicolas-grekas
Copy link
Member

Thank you @martkop26.

@nicolas-grekas nicolas-grekas merged commit f8d4168 into symfony:5.4 Sep 8, 2022
This was referenced Sep 30, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug HttpClient Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[HttpClientBundle] RetryableHttpClient invalid delay
4 participants
@martkop26 @carsonbot @nicolas-grekas @xabbuh