Skip to content

[HttpFoundation] Always return strings from accept headers #47530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

[HttpFoundation] Always return strings from accept headers #47530

merged 1 commit into from
Sep 9, 2022

Conversation

ausi
Copy link
Contributor

@ausi ausi commented Sep 9, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Items retrieved from the Accept HTTP headers should always be strings.

Related: contao/contao#5261

@carsonbot carsonbot added this to the 5.4 milestone Sep 9, 2022
@ausi ausi mentioned this pull request Sep 9, 2022
Closed
@carsonbot carsonbot changed the title Always return strings from accept headers [HttpFoundation] Always return strings from accept headers Sep 9, 2022
@xabbuh xabbuh modified the milestones: 5.4, 4.4 Sep 9, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 September 9, 2022 16:01
@nicolas-grekas nicolas-grekas force-pushed the fix/accept-header-string-type branch from 6ba174c to abddada Compare September 9, 2022 16:01
nicolas-grekas
nicolas-grekas approved these changes Sep 9, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I changed the target of the PR to 4.4)

@fabpot
Copy link
Member

fabpot commented Sep 9, 2022

Thank you @ausi.

@fabpot fabpot merged commit 7023db1 into symfony:4.4 Sep 9, 2022
This was referenced Sep 30, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@xabbuh xabbuh xabbuh approved these changes

@fritzmg fritzmg fritzmg approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

Assignees
No one assigned
Labels
Bug HttpFoundation Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@ausi @fabpot @nicolas-grekas @stof @xabbuh @fritzmg @carsonbot