Skip to content

[FrameworkBundle] Fix checkboxes check assertions #47946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

[FrameworkBundle] Fix checkboxes check assertions #47946

merged 1 commit into from
Feb 10, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47830
License MIT
Doc PR N/A

The CssSelector component knows better about the checked state!

@carsonbot carsonbot added this to the 5.4 milestone Oct 21, 2022
@MatTheCat MatTheCat force-pushed the ticket_47830 branch 2 times, most recently from 4dc833d to c852207 Compare October 21, 2022 15:15
@MatTheCat MatTheCat force-pushed the ticket_47830 branch 3 times, most recently from 94ecd3a to fd48628 Compare November 20, 2022 19:10
@MatTheCat MatTheCat force-pushed the ticket_47830 branch 2 times, most recently from 0dcac8a to de5b642 Compare November 28, 2022 15:15
@MatTheCat MatTheCat force-pushed the ticket_47830 branch 2 times, most recently from 4f5d305 to cc417ac Compare February 7, 2023 08:07
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit 01409a5 into symfony:5.4 Feb 10, 2023
@MatTheCat MatTheCat deleted the ticket_47830 branch February 10, 2023 14:10
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendavies bendavies bendavies left review comments

@xabbuh xabbuh xabbuh left review comments

@maxbeckers maxbeckers maxbeckers left review comments

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@MatTheCat @nicolas-grekas @bendavies @xabbuh @maxbeckers @carsonbot