Skip to content

[HttpKernel] Fix deprecation for DateTimeValueResolver with null on non-nullable argument #48110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2022
Merged

[HttpKernel] Fix deprecation for DateTimeValueResolver with null on non-nullable argument #48110

merged 1 commit into from
Nov 4, 2022

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Nov 4, 2022 •
edited
Loading

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets https://github.com/symfony/symfony/pull/48098/files#r1013918566
License MIT
Doc PR n/a

Remove deprecation message when the value is null and the controller argument is not nullable.

Deprecated: DateTimeImmutable::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated

This class have been modified in 6.2. The new test case needs to be updated.

@GromNaN GromNaN requested a review from stof November 4, 2022 12:06
@carsonbot carsonbot changed the title Fix deprecation for DateTimeValueResolver with null on non-nullable argument [HttpKernel] Fix deprecation for DateTimeValueResolver with null on non-nullable argument Nov 4, 2022
@carsonbot carsonbot added this to the 6.1 milestone Nov 4, 2022
@GromNaN GromNaN mentioned this pull request Nov 4, 2022
Merged
@nicolas-grekas
Copy link
Member

Thank you @GromNaN.

@nicolas-grekas nicolas-grekas merged commit b2a35c7 into symfony:6.1 Nov 4, 2022
@GromNaN GromNaN deleted the fix-datetime-deprecation branch November 4, 2022 14:25
@fabpot fabpot mentioned this pull request Nov 19, 2022
Merged
@fabpot fabpot mentioned this pull request Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof Awaiting requested review from stof

Assignees
No one assigned
Labels
Bug HttpKernel Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @nicolas-grekas @carsonbot