[PhpUnitBridge] Fix language deprecations incorrectly marked as direct #48122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "4.4". Cheers! Carsonbot |
c874e8e to
dfac00a
Compare
|
Hey! I think @michaelKaefer has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
maxbeckers
reviewed
Nov 7, 2022
src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler/Deprecation.php
Outdated
Show resolved
Hide resolved
dfac00a to
481a8c7
Compare
maxbeckers
approved these changes
Nov 9, 2022
fabpot
approved these changes
Nov 11, 2022
|
Thank you @wouterj. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a vendor class that has a language deprecation (e.g. missing
__serializemethods), these deprecations were incorrectly considered "direct".