Skip to content

[HttpKernel] Don’t try to wire Response argument with controller.service_arguments #48172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

[HttpKernel] Don’t try to wire Response argument with controller.service_arguments #48172

merged 1 commit into from
Nov 9, 2022

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Nov 9, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48138
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.2 milestone Nov 9, 2022
@MatTheCat MatTheCat mentioned this pull request Nov 9, 2022
Closed
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 5.4 Nov 9, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 5.4 November 9, 2022 11:21
@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit a671816 into symfony:5.4 Nov 9, 2022
@MatTheCat MatTheCat deleted the ticket_48138 branch November 9, 2022 11:28
@fabpot fabpot mentioned this pull request Nov 19, 2022
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug HttpKernel Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] Optimized autowiring breaks existing installations
3 participants
@MatTheCat @nicolas-grekas @carsonbot