Skip to content

[Messenger] Fix time-limit check exception #48198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

[Messenger] Fix time-limit check exception #48198

merged 1 commit into from
Nov 14, 2022

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Nov 11, 2022 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48196
License MIT
Doc PR symfony/symfony-docs#...

Check on time-limit was invalid.

(Unrelated fabbot failure)

@carsonbot carsonbot added this to the 4.4 milestone Nov 11, 2022
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "4.4" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@alamirault alamirault mentioned this pull request Nov 11, 2022
Closed
maxbeckers
maxbeckers approved these changes Nov 12, 2022
View reviewed changes
Copy link
Contributor

@maxbeckers maxbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! And thanks for the test.

Please have a look at the fabbot.

@nicolas-grekas
Copy link
Member

Thank you @alamirault.

@nicolas-grekas nicolas-grekas force-pushed the hotfix/48196-fix-messenger-consume-limit branch from a8b4ddb to a13b41a Compare November 14, 2022 09:53
@nicolas-grekas nicolas-grekas merged commit 63221f0 into symfony:4.4 Nov 14, 2022
@fabpot fabpot mentioned this pull request Nov 19, 2022
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @carsonbot @nicolas-grekas @maxbeckers