[Security] Make onAuthenticationSuccess Response optional #48288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "6.2" but it seems your PR description refers to branch "6.3 for features / 4.4, 5.4, 6.0, 6.1, or 6.2 for bug fixes ". Cheers! Carsonbot |
fabpot
reviewed
Dec 9, 2022
src/Symfony/Component/Security/Http/Authentication/AuthenticationSuccessHandlerInterface.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
I'd merge this as a regular bugfix: in 5.4, returning null was allowed and handled by the code.
See #50092
|
Thank you @db306. |
fabpot
added a commit
that referenced
this pull request
Apr 21, 2023
…(db306) This PR was merged into the 6.2 branch. Discussion ---------- [Security] Make onAuthenticationSuccess Response optional | Q | A | ------------- | --- | Branch? | 6.0, 6.1, and 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT Most authenticators currently use onAuthenticationSuccess with an optional Response. That's mainly due to usecases whereby we want to redirect specific users etc. Commits ------- 1e95ac7 Make onAuthenticationSuccess Response optional
fabpot
added a commit
that referenced
this pull request
Apr 21, 2023
…Interface::onAuthenticationSuccess() (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Security] Fix return type of AuthenticationSuccessHandlerInterface::onAuthenticationSuccess() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Relates to #48288 Note that callers of this method are already null-aware. Commits ------- 7e35ba0 [Security] Fix return type of AuthenticationSuccessHandlerInterface::onAuthenticationSuccess()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most authenticators currently use onAuthenticationSuccess with an optional Response. That's mainly due to usecases whereby we want to redirect specific users etc.