Skip to content

[RateLimiter] Add int to Reservation::wait() #48501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

[RateLimiter] Add int to Reservation::wait() #48501

merged 1 commit into from
Dec 9, 2022

Conversation

DaRealFreak
Copy link
Contributor

@DaRealFreak DaRealFreak commented Dec 5, 2022 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48500
License MIT

The usleep function accepts int as parameter type (https://www.php.net/manual/en/function.usleep.php), while the passed type is float in Reservation::wait (due to Reservation::getWaitDuration returning a float value for the 1e6 multiplication)
To prevent deprecation notices we can typecast the float value to int before passing it to usleep

@carsonbot carsonbot added this to the 6.3 milestone Dec 5, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.3" but it seems your PR description refers to branch "6.2".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark OskarStark changed the title [RateLimiter] Add typecast to Reservation::wait [RateLimiter] Add typecast to Reservation::wait() Dec 5, 2022
@OskarStark OskarStark changed the title [RateLimiter] Add typecast to Reservation::wait() [RateLimiter] Add int to Reservation::wait() Dec 5, 2022
@nicolas-grekas nicolas-grekas modified the milestones: 6.3, 5.4 Dec 9, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 6.3 to 5.4 December 9, 2022 07:37
@nicolas-grekas
Copy link
Member

Thank you @DaRealFreak.

@nicolas-grekas nicolas-grekas merged commit e807503 into symfony:5.4 Dec 9, 2022
@fabpot fabpot mentioned this pull request Dec 16, 2022
Merged
This was referenced Dec 28, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug RateLimiter Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[RateLimiter] Implicit conversion from float to int losing precision in Reservation.php
3 participants
@DaRealFreak @carsonbot @nicolas-grekas