Skip to content

[DoctrineBridge] Fix detecting mapping with one line annotations #48896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

[DoctrineBridge] Fix detecting mapping with one line annotations #48896

merged 1 commit into from
Jan 9, 2023

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Jan 6, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

When using one line comment (which is enabled by default when using doctrine/coding-standard 11) to specify that a class is an Entity:

/** @Entity */
class Person 
{
    // ...
}

it doesn't detect properly the annotation and returns attribute instead of annotation.

@carsonbot carsonbot added this to the 5.4 milestone Jan 6, 2023
@nicolas-grekas
Copy link
Member

Thank you @franmomu.

@nicolas-grekas nicolas-grekas merged commit 05582da into symfony:5.4 Jan 9, 2023
@franmomu franmomu deleted the fix_mapping_one_line branch January 9, 2023 09:28
This was referenced Jan 24, 2023
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@franmomu @nicolas-grekas @xabbuh @carsonbot