[Validator] Handle object properties in Unique validator #48951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
artyuum
suggested changes
Jan 12, 2023
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
Seb33300
reviewed
Jan 13, 2023
3953218 to
c14e90e
Compare
|
would be nice to push this forward. |
c14e90e to
d3acea4
Compare
|
@plfort can you resolve conflict? We really need this functionality and it would be cool to merge this, thanks in advance! |
d3acea4 to
6a7c1af
Compare
|
Rebased on 7.2 |
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Constraints/UniqueValidator.php
Outdated
Show resolved
Hide resolved
Fix after rebase Update CHANGELOG.md
Co-authored-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
Co-authored-by: Artyum <didifsx@hotmail.fr>
Co-authored-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
5c71b96 to
3f169ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
Uniqueconstraint to access object properties.Simple public object properties are handled directly, otherwise we rely on
PropertyAccesscomponent to read the value.This PR is an improvement of #47714