Skip to content

[DependencyInjection] Fix combinatory explosion when autowiring union and intersection types #49128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

[DependencyInjection] Fix combinatory explosion when autowiring union and intersection types #49128

merged 1 commit into from
Feb 1, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #49105
License MIT
Doc PR -

The performance is so bad in the reported situation that this is a bugfix.

@carsonbot carsonbot added this to the 5.4 milestone Jan 27, 2023
@stof stof mentioned this pull request Jan 27, 2023
Closed
@nicolas-grekas nicolas-grekas merged commit 393c603 into symfony:5.4 Feb 1, 2023
@nicolas-grekas nicolas-grekas deleted the di-combined-aliases-perf branch February 7, 2023 10:43
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug DependencyInjection Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot