Skip to content

[PropertyInfo] Add meaningful message when phpstan/phpdoc-parser is not installed when using PhpStanExtractor #49207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets NA
License MIT
Doc PR NA

Folow-up of #49146, as phpstan/phpdoc-parser is only defined in require-dev of PropertyInfo.

Also, I took this opportunity to convert a few data providers to static ones cc @OskarStark 👍

… not installed when using `PhpStanExtractor`
@alexandre-daubois alexandre-daubois force-pushed the fix-phpstanextractor-requirement branch from 27e65d9 to 404d6cc Compare February 2, 2023 20:11
@fabpot
Copy link
Member

fabpot commented Feb 4, 2023

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 1db371f into symfony:5.4 Feb 4, 2023
@alexandre-daubois alexandre-daubois deleted the fix-phpstanextractor-requirement branch February 4, 2023 08:23
This was referenced Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants