Skip to content

[VarExporter] Fix lazy-proxying readonly classes on PHP 8.3 #49282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2023
Merged

[VarExporter] Fix lazy-proxying readonly classes on PHP 8.3 #49282

merged 1 commit into from
Feb 7, 2023

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Feb 7, 2023 •
edited
Loading

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? n
Tickets -
License MIT
Doc PR -

Now that https://wiki.php.net/rfc/readonly_amendments has been accepted, I figured out the design of LazyProxyTrait needs some tweaks to support readonly classes.

This basically move the LazyProxyTrait::$lazyObjectReal property to LazyObjectState::$realInstance.

@carsonbot carsonbot added this to the 6.2 milestone Feb 7, 2023
@nicolas-grekas nicolas-grekas force-pushed the ve-readonly-proxy branch 3 times, most recently from 849bd8a to a26eb01 Compare February 7, 2023 15:21
@nicolas-grekas nicolas-grekas merged commit f910435 into symfony:6.2 Feb 7, 2023
@nicolas-grekas nicolas-grekas deleted the ve-readonly-proxy branch February 7, 2023 15:44
@fabpot fabpot mentioned this pull request Feb 28, 2023
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Apr 6, 2023
Closed
@xabbuh xabbuh mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review VarExporter
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot