Skip to content

[Security] Implemented the Serializable interface in the Role class #4934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Security] Implemented the Serializable interface in the Role class #4934

wants to merge 1 commit into from
+36 −1

Conversation

stof
Copy link
Member

@stof stof commented Jul 15, 2012

This reopens a PR to discuss the changes as #4925 was merged by mistake and reverted.

@Koc
Copy link
Contributor

Koc commented Jul 15, 2012

Maybe you should add to doc information that developer should invalidate all users sessions.

@fabpot
Copy link
Member

fabpot commented Jul 18, 2012

This is a BC break for people extending the Role class and I'm not sure it is worth it:

Before:

1:{s:47:"\0Symfony\Component\Security\Core\Role\Role\0role";s:9:"ROLE_USER";}}

After:

16:{s:9:"ROLE_USER";}}

Length is 23 vs 79 for a role.

So, -1.

@fabpot
Copy link
Member

fabpot commented Sep 28, 2012

Closing it as it's not worth it to break BC for such a small benefit.

@fabpot fabpot closed this Sep 28, 2012
This was referenced Feb 2, 2014
Closed
Closed
@stof stof deleted the serializable_role branch April 8, 2014 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stof @Koc @fabpot