Skip to content

[WebProfilerBundle] Fix the rendering of query explanation with Postgresql #49477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

stof
Copy link
Member

@stof stof commented Feb 21, 2023

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR n/a

Postgresql (and some other platforms) provide a textual query explanation rather than a tabular one.
The previous styles were working only for a tabular display. For text allowing to break words, min-content is the width of a single letter.

With the old code (introduced in #46750), a query explanation looks like that when using Postgresql (well, with a lot more lines that what is included in the screenshot):
image

After the change, it looks like that (including only the first few lines), which is a lot easier to read:
image

Postgresql (and some other platforms) provide a textual query
explanation rather than a tabular one.
The previous styles were working only for a tabular display. For text
allowing to break words, `min-content` is the width of a single letter.
@nicolas-grekas
Copy link
Member

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit 0a9a264 into symfony:6.2 Feb 21, 2023
@stof stof deleted the fix_sql_explain branch February 22, 2023 15:00
@fabpot fabpot mentioned this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants