Skip to content

[Scheduler] allow MessageGenerator's to return RecurringMessage[] #49865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Scheduler] allow MessageGenerator's to return RecurringMessage[] #49865

wants to merge 1 commit into from

Conversation

kbond
Copy link
Member

@kbond kbond commented Mar 29, 2023

Q A
Branch? 6.3
Bug fix? no
New feature? yes
Deprecations? no
Tickets n/a
License MIT
Doc PR todo
  • Ensures SchedulerTransport returns RecurringMessage[]
  • Adds RecurringMessage to ScheduledStamp.

As discussed in #49838 and a companion to #49864.

@carsonbot carsonbot added Status: Needs Review Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Scheduler labels Mar 29, 2023
@carsonbot carsonbot added this to the 6.3 milestone Mar 29, 2023
@carsonbot carsonbot changed the title [Scheduler][RFC] allow MessageGenerator's to return RecurringMessage[] [Scheduler] allow MessageGenerator's to return RecurringMessage[] Mar 29, 2023
@kbond
Copy link
Member Author

kbond commented Mar 29, 2023

I'm not entirely happy with this solution so looking for other ideas. I'd prefer if we enforced MessageGeneratorInterface::getMessages(): RecurringMessage[]. I guess we're assuming someone could make their own implementation that doesn't use RecurringMessages?

@kbond
[Scheduler] allow MessageGenerator's to return RecurringMessage[]
cede63f 
- Add `RecurringMessage` to `ScheduledStamp`.
@kbond kbond force-pushed the scheduler-get-recurring-message branch from 45239eb to cede63f Compare March 29, 2023 21:54
This was referenced Apr 20, 2023
Closed
Closed
@kbond
Copy link
Member Author

kbond commented Apr 24, 2023

Closing in favour of #50130.

@kbond kbond closed this Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature RFC RFC = Request For Comments (proposals about features that you want to be discussed) Scheduler Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kbond @carsonbot