-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[PhpUnitBridge] Fix PHPUnit 10.1 compatibility #50048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm honestly not quite sure how to fix the psalm issues. One of the class names is always undefined no matter which PHPUnit version is used. 🤔 |
Thank you @enumag. |
hey @nicolas-grekas and @enumag I am somewhat confused by this PR/commit. This is on branch 5.4. Does this mean 5.4 is getting (or already has) support for PHPUnit 10? If so, should these be closed? Also, @nicolas-grekas, if you work with |
hmm I'm not sure which version of phpunit does the 5.4 version support as composer.json doesn't say... if it doesn't support v10 then maybe it doesn't belong into 5.4? I just targeted the oldest supported version as is usual for bugs... |
@enumag are you running symfony 5.4 with phpunit-bridge and phpunit 10? |
@arderyp According to my composer.json that is the case, yes. I did update to 6.0 while I was trying to resolve the issues but I did have phpunit 10 along with phpunit-bridge 5.x for a while. |
Yeah, composer doesn't restrict it, but I am unable to run phpunit 10 and phpunit-bridge side by side on my Symfony 5.4 project. As far as I know, bridge has not been updated to handle integration into phpunit 10 yet. If I drop phpunit-bridge via composer, phpunit 10 runs fine with my setup otherwise. |
PHPUnit 10.1 moved the ErrorHandler class again. See sebastianbergmann/phpunit@9e60ead