Skip to content

[WebProfilerBundle] Fix error in case of 'Content-Type' set null in dev environment with no debug #51000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

[WebProfilerBundle] Fix error in case of 'Content-Type' set null in dev environment with no debug #51000

merged 1 commit into from
Jul 19, 2023

Conversation

alexbuyanow
Copy link
Contributor

@alexbuyanow alexbuyanow commented Jul 17, 2023 •
edited by fancyweb
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #50977
License MIT
Doc PR -

@carsonbot carsonbot added this to the 5.4 milestone Jul 17, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@fancyweb fancyweb changed the title [WebProfiler] Fix error in case of 'Content-Type' set null in dev environment with no debug [WebProfilerBundle] Fix error in case of 'Content-Type' set null in dev environment with no debug Jul 17, 2023
@nicolas-grekas nicolas-grekas force-pushed the fix-null-content-type branch from 7b7f798 to 6faed31 Compare July 19, 2023 19:34
@nicolas-grekas
Copy link
Member

Thank you @alexbuyanow.

@nicolas-grekas nicolas-grekas merged commit d79796b into symfony:5.4 Jul 19, 2023
@HypeMC HypeMC mentioned this pull request Jul 19, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 20, 2023
@nicolas-grekas
minor #51032 [HttpFoundation][HttpKernel] Fix deprecations when `Cont…
d09a9dc 
…ent-Type` is `null` (HypeMC)

This PR was merged into the 5.4 branch.

Discussion
----------

[HttpFoundation][HttpKernel] Fix deprecations when `Content-Type` is `null`

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Followup to #51000. Two more places I discovered were triggering deprecations when `Content-Type` is `null`.

Commits
-------

678d7be [HttpFoundation][HttpKernel] Fix deprecations when `Content-Type` is `null`
This was referenced Jul 29, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fancyweb fancyweb fancyweb approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexbuyanow @carsonbot @nicolas-grekas @fancyweb