[Process] Fix bug where $this->callback is never null, resulting in bad argument #51478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a way to write a test catching this, so that we don't have similar regressions ? |
|
Test added 👍 |
fabpot
approved these changes
Oct 16, 2023
a7f0739 to
95aa236
Compare
|
Thank you @weaverryan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Caused by #51068 - by the time
$this->getDescriptors()is called,$this->callbackis ALWAYS a callable thanks to$this->callback = $this->buildCallback($callback).Previously, there was a separate
hasCallbackproperty that handled this logic. I chose to NOT re-add that because it was only needed ingetDescriptors()and that is only called from this one place: easier to pass$hasCallbackas an argument.Caught by the symfony/ux test suite ❤️
Cheers!