[HttpFoundation] do not access properties before initialization #51904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 9, 2023
| Q | A |
|---|---|
| Branch? | 7.0 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | |
| License | MIT |
|
the right solution is actually to add a |
|
changed it to initialise the properties with |
stof
reviewed
Oct 9, 2023
|
|
||
| protected static ?\Closure $requestFactory = null; | ||
|
|
||
| private string $preferredFormat; | ||
| private ?string $preferredFormat = null; |
There was a problem hiding this comment.
I don't think this one needs to be changed. As it is a private method, we can fully control the lazy initialization and the code handling it was fine (as we use ??=)
There was a problem hiding this comment.
we can keep it as is, but then we need to update getPreferredFormat() to not assign null to this property (changes pushed)
There was a problem hiding this comment.
ah, I missed that we were sometimes assigning null
4 tasks
fabpot
approved these changes
Oct 10, 2023
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.