Skip to content

Fix CI #52045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix CI #52045

merged 1 commit into from
Oct 13, 2023

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

@fancyweb fancyweb requested a review from OskarStark as a code owner October 13, 2023 12:52
@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2023
fancyweb
fancyweb commented Oct 13, 2023
View reviewed changes
fancyweb
fancyweb commented Oct 13, 2023
View reviewed changes
src/Symfony/Component/Clock/Test/ClockSensitiveTrait.php
@@ -35,7 +35,7 @@ public static function mockTime(string|\DateTimeImmutable|bool $when = true): Cl
false === $when => self::saveClockBeforeTest(false),
true === $when => new MockClock(),
$when instanceof \DateTimeImmutable => new MockClock($when),
default => new MockClock(now()->modify($when)),
default => new MockClock(now($when)),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Necessary so the timezone is taken into account

@nicolas-grekas
Copy link
Member

Thank you @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 106a19f into symfony:6.4 Oct 13, 2023
@fancyweb fancyweb deleted the ci/fix-windows-64 branch October 13, 2023 15:28
@xabbuh xabbuh mentioned this pull request Oct 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fancyweb @nicolas-grekas @carsonbot