Skip to content

[Mime] Add TemplatedEmail::$locale to the serialized props #52719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2023
Merged

[Mime] Add TemplatedEmail::$locale to the serialized props #52719

merged 1 commit into from
Nov 25, 2023

Conversation

mkrauser
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #52718
License MIT

To use the locale-property when working with Symfony Messenger asynchronously it has to be serialized.

@carsonbot carsonbot added this to the 7.1 milestone Nov 24, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "6.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@mkrauser mkrauser changed the base branch from 7.1 to 6.4 November 24, 2023 14:54
nicolas-grekas
nicolas-grekas reviewed Nov 24, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions that should help provide some compat with previously serialized payloads

@OskarStark OskarStark changed the title [Mime] Add TemplatedEmail::$locale to the serialized props [Mime] Add TemplatedEmail::$locale to the serialized props Nov 24, 2023
@fabpot fabpot modified the milestones: 7.1, 5.4, 6.4 Nov 25, 2023
@fabpot
Copy link
Member

fabpot commented Nov 25, 2023

Thank you @mkrauser.

@fabpot fabpot merged commit 0c9985c into symfony:6.4 Nov 25, 2023
This was referenced Nov 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@welcoMattic welcoMattic Awaiting requested review from welcoMattic

Assignees
No one assigned
Labels
Bug Mime Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Mime]TemplatedEmail::$locale is not serialized
5 participants
@mkrauser @carsonbot @fabpot @nicolas-grekas @OskarStark