Skip to content

[Notifier] Add sms-sluzba.cz bridge #52976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

[Notifier] Add sms-sluzba.cz bridge #52976

merged 1 commit into from
Dec 28, 2023

Conversation

dfridrich
Copy link
Contributor

@dfridrich dfridrich commented Dec 9, 2023 •
edited by OskarStark
Loading

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #52975
License MIT

Adding support for sms-sluzba.cz as I mention in

@dfridrich dfridrich requested a review from OskarStark as a code owner December 9, 2023 16:45
@carsonbot carsonbot added this to the 7.1 milestone Dec 9, 2023
OskarStark
OskarStark reviewed Dec 9, 2023
View reviewed changes
OskarStark
OskarStark reviewed Dec 9, 2023
View reviewed changes
OskarStark
OskarStark reviewed Dec 9, 2023
View reviewed changes
OskarStark
OskarStark requested changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update UnsupportedSchemeException + test in the notifier component, thanks

It would also be very helpful if you could provide a PR against symfony/symfony-docs and symfony/recipes repo.

@carsonbot carsonbot changed the title Add sms-sluzba.cz Notifier Bridge [Notifier] Add sms-sluzba.cz Notifier Bridge Dec 9, 2023
@OskarStark OskarStark changed the title [Notifier] Add sms-sluzba.cz Notifier Bridge [Notifier] Add sms-sluzba.cz bridge Dec 9, 2023
dfridrich added a commit to dfridrich/symfony-docs that referenced this pull request Dec 10, 2023
@dfridrich
[WCM] [Notifier] Add info about SMS Sluzba notifier
8684d1c 
symfony/symfony#52976
@dfridrich dfridrich mentioned this pull request Dec 10, 2023
Merged
OskarStark
OskarStark reviewed Dec 11, 2023
View reviewed changes
OskarStark
OskarStark reviewed Dec 11, 2023
View reviewed changes
OskarStark
OskarStark reviewed Dec 11, 2023
View reviewed changes
OskarStark
OskarStark requested changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your bridge to UnsupportedSchemeExceptionTest, thanks

@OskarStark OskarStark requested a review from xabbuh December 11, 2023 08:41
Nyholm
Nyholm reviewed Dec 19, 2023
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Looks good. I just have a minor comment

@OskarStark
Copy link
Contributor

Please add your bridge to UnsupportedSchemeExceptionTest, thanks

I pushed to your branch

@OskarStark
Copy link
Contributor

I fixed CS errors mentioned by fabbot.io and rebased on top of 7.1

Good to merge from my side @fabpot 👍

@OskarStark OskarStark requested a review from fabpot December 28, 2023 08:59
@fabpot
Copy link
Member

fabpot commented Dec 28, 2023

Thank you @dfridrich.

@fabpot fabpot merged commit edfba7a into symfony:7.1 Dec 28, 2023
@fabpot fabpot mentioned this pull request Dec 28, 2023
Closed
OskarStark pushed a commit to dfridrich/symfony-docs that referenced this pull request Dec 28, 2023
@dfridrich @OskarStark
[WCM] [Notifier] Add info about SMS Sluzba notifier
3bff65b 
symfony/symfony#52976
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Dec 28, 2023
@OskarStark
feature #19258 [Notifier] Add docs of sms-sluzba.cz bridge (dfridrich)
9a00038 
This PR was squashed before being merged into the 7.1 branch.

Discussion
----------

[Notifier] Add docs of sms-sluzba.cz bridge

symfony/symfony#52976

Commits
-------

9513283 [Notifier] Add docs of sms-sluzba.cz bridge
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm left review comments

@franckranaivo franckranaivo franckranaivo left review comments

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

[Notifier] Add SmsSluzba.cz support
6 participants
@dfridrich @OskarStark @fabpot @Nyholm @franckranaivo @carsonbot