[HttpKernel] fix "Cannot redeclare renderSymfonyLogoSvg()" inside phpunit tests #53239
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
|
LGTM, but should probably be done on 5.4, right? |
|
Thank you @davidesigner. |
…peMC) This PR was merged into the 7.0 branch. Discussion ---------- [HttpKernel] Fix including welcome page multiple times | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #53686 | License | MIT Reverts #53239 & switches to using closures instead. Commits ------- 4e55227 [HttpKernel] Fix including welcome page multiple times
In a PHPUnit test case with dataProvider, there was a fatal error:
This include_once fix the error.