-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] grab a service from the container only if it exists #53572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Jan 18, 2024
•
edited
Loading
edited
Q | A |
---|---|
Branch? | 6.3 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Issues | Fix #53551 |
License | MIT |
The root cause for the observed behaviour is that the list of pool names passed to the constructor of |
Can't we check if the service exists before accessing it? Because this strategy is going to keep around pools that are not used, preventing them to be cleaned up by the compilation process. |
indeed, that's a better idea |
Why the Validator label? |
probably because I made a typo in the initial title and didn't remove the label when fixing that so Carson re-adds it again |
src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor tweak
Thank you @xabbuh. |