Skip to content

[Yaml] Revert "feature #48022 Fix Yaml Parser with quote end in a newline (maxbeckers)" #53747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2024
Merged

[Yaml] Revert "feature #48022 Fix Yaml Parser with quote end in a newline (maxbeckers)" #53747

merged 1 commit into from
Feb 3, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 3, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Unfortunately, the features as implemented breaks tests in other bundles (see https://github.com/symfony/symfony/actions/runs/7768721075/job/21186968515?pr=53745#step:8:3092).

@xabbuh
Revert "feature symfony#48022 [Yaml] Fix Yaml Parser with quote end i…
d709af0 
…n a new line (maxbeckers)"

This reverts commit 40a2cfb, reversing
changes made to d2d36b5.
@carsonbot carsonbot added this to the 7.1 milestone Feb 3, 2024
@carsonbot carsonbot changed the title Revert "feature #48022 [Yaml] Fix Yaml Parser with quote end in a newline (maxbeckers)" [Yaml] Revert "feature #48022 Fix Yaml Parser with quote end in a newline (maxbeckers)" Feb 3, 2024
@xabbuh xabbuh mentioned this pull request Feb 3, 2024
Merged
@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

Thank you @xabbuh.

@fabpot fabpot merged commit acb4372 into symfony:7.1 Feb 3, 2024
@fabpot fabpot mentioned this pull request Feb 3, 2024
Closed
@xabbuh xabbuh deleted the pr-48022 branch February 3, 2024 21:10
@fabpot fabpot mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @fabpot @carsonbot