I just confirmed on a real app that this solves all ambiguities while providing nice DX.

rebase needed and 👍

Thank you @nicolas-grekas.

In https://symfony.com/blog/new-in-symfony-7-1-mapped-route-parameters it says

Given that this new feature provides a nice DX (developer experience) and is very concise, we've decided to deprecate the automatic mapping of route parameters into Doctrine entities starting from Symfony 7.1.

I counter that argument. Deprecating a feature that works since years is not a great DX. This one feels different than other deprecations, as it requires so many route to be manually adjusted. I understand it if there are multiple Entities and parameters, but if only one {id} is set and only one Entity is used, isn't it obvious which one is meant?

the usage of {id} to find by primary key was not part of the auto-mapping feature. @nicolas-grekas I think this should deserve a separate deprecation message (and probably a separate changelog entry)

My feedback is purely based on this example in the Blog entry:

Do I misunderstand something? Is it deprecated or not?

Considering the note:

Given that this new feature provides a nice DX

I honestly don't see how this change is a win from DX side. Looks more like unnecessary repetition to me.
I really fear having to adjust and test hundreds of routes across several projects.

The {id:document} mapping in the last example in the blog post is not needed indeed.
What matters is having explicit mapping and using {document} should be the way to go.
/cc @javiereguiluz FYI

@nicolas-grekas thanks for the update. I agree that {document} is better to understand and should be used. But in the past {id} was documented and is likely used in tenth of thousands of routes out there.
So my question and hope remains: {id} keeps on working without a deprecation?

Follow up at #57211

@nicolas-grekas @kevinpapst from the point of view of generating URLs in templates:

<a href="{{ path('document_show', {id: document.id}) }}"> ... </a>

This looks better than the following:

<a href="{{ path('document_show', {document: document.id}) }}"> ... </a>

A document is not the same as document ID. That's why I kept the {id} parameter in the route and mapped it to the controller's document argument.

But maybe I'm missing something here.

Hey, thanks for this feature! I've tried implementing it but came around an interrogation: what happens if I want to find multiple entities... from their ids?
For instance, if I want to access a bill and its receipt, I was thinking of doing:

#[Route(path: '/voir/{id:bill}/{id:receipt}', name: 'show_bill_and_receipt')]
public function showBillAndReceipt(Bill $bill, Receipt $receipt): Response
{
    // Here the hypothetical queries ran by the Doctrine Bridge would have been:
    // $bill= $billRepository->findOneBy(['id' => 'the bill's id']);
    // $receipt= $receiptRepository->findOneBy(['id' => 'the receipt's id']);
}

And to create the related link in the UI:

{{ path('show_bill_and_receipt', {'id:bill': bill.id, 'id:receipt': receipt.id})} }}

This way I thought I could have benefitted from the best of Mapped Route Parameters and Doctrine Bridge.

Do you think of a way I could make this work without using the #[MapEntity()] attribute, or it would be impossible to do so in the current state of the mapped query parameters?

Sorry if I'm not in the right Conversation to ask this question, if you want I can open an Issue dedicated to this question.

@Narthall just drop the id: from your parameter (assuming id is the identifier of your entity).

#[Route(path: '/voir/{bill}/{receipt}', name: 'show_bill_and_receipt')]
public function showBillAndReceipt(Bill $bill, Receipt $receipt): Response

@Narthall

If the bill and receipt are linked, the more standard way would be

#[Route(path: '/voir/{id:bill}', name: 'show_bill_and_receipt')]
public function showBillAndReceipt(Bill $bill): Response
{
    $receipt = $bill->getReceipt();
}

which guarantees that you get the related receipt.

If you really want to fetch both from the url, you could do

#[Route(path: '/voir/{bill_id:bill}/{receipt_id:receipt}', name: 'show_bill_and_receipt')]
public function showBillAndReceipt(Bill $bill, Receipt $receipt): Response
{
}

Hey, thanks for this feature! I've tried implementing it but came around an interrogation: what happens if I want to find multiple entities... from their ids? For instance, if I want to access a bill and its receipt, I was thinking of doing:

#[Route(path: '/voir/{id:bill}/{id:receipt}', name: 'show_bill_and_receipt')]
public function showBillAndReceipt(Bill $bill, Receipt $receipt): Response
{
    // Here the hypothetical queries ran by the Doctrine Bridge would have been:
    // $bill= $billRepository->findOneBy(['id' => 'the bill's id']);
    // $receipt= $receiptRepository->findOneBy(['id' => 'the receipt's id']);
}

And to create the related link in the UI:

{{ path('show_bill_and_receipt', {'id:bill': bill.id, 'id:receipt': receipt.id})} }}

This way I thought I could have benefitted from the best of Mapped Route Parameters and Doctrine Bridge.

Do you think of a way I could make this work without using the #[MapEntity()] attribute, or it would be impossible to do so in the current state of the mapped query parameters?

Sorry if I'm not in the right Conversation to ask this question, if you want I can open an Issue dedicated to this question.

@Narthall I worked on it : #59904