[AssetMapper][FrameworkBundle] Do not require http_client service
#57073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "6.4". Cheers! Carsonbot |
http_client servicehttp_client service
|
@carsonbot done |
http_client servicehttp_client service
http_client servicehttp_client service
derrabus
approved these changes
May 23, 2024
nicolas-grekas
approved these changes
May 23, 2024
OskarStark
approved these changes
May 23, 2024
|
Ah: why do you consider this as a bugfix? To me it's for 7.2 |
|
To me it's a bug and not a feature? It's not working without the service defined. |
xabbuh
reviewed
May 23, 2024
| ) { | ||
| $this->httpClient = $httpClient ?? HttpClient::create(); |
There was a problem hiding this comment.
The changes here do not qualify as a bugfix to me. I think for 6.4 we should remove the asset mapper services instead that require the http_client service.
There was a problem hiding this comment.
here is a PR implementing my suggestion: #57219
fabpot
approved these changes
May 25, 2024
This makes it possible to use AssetMapper with `http_client` disabled on the framework.
Example:
```php
$configurator->extension(
'framework',
[
'http_client' => [
'enabled' => false,
],
'asset_mapper' => [
'paths' => [
'assets/',
],
],
]
);
```
ce00298 to
b5e39ec
Compare
|
Thank you @ruudk. |
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Jun 26, 2024
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2024
…se asset-mapper while http-client is disabled (nicolas-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Throw runtime exception when trying to use asset-mapper while http-client is disabled | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Replaces #57219 and #57073 Commits ------- df133a9 [FrameworkBundle] Throw runtime exception when trying to use asset-mapper while http-client is disabled
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to use AssetMapper with
http_clientdisabled on the framework.It will automatically instantiate the required HttpClient.
Example:
This fixes the following problems: