Skip to content

[AssetMapper] fix npm version constraint conversion #57321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

Jean-Beru
Copy link
Contributor

@Jean-Beru Jean-Beru commented Jun 5, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #54610
License MIT

This PR fixes semver conversion when requiring or updating packages.

[warning] datatables.net-scroller-bs5 requires datatables.net-bs5@1.11 - 2 but version 2.0.3 is installed.

Ranges are now converted to 1.11 - 2 instead of >=1.11 <=2.

See #54610

Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why we had this change in place since composer supports ranges too.

@fabpot
Copy link
Member

fabpot commented Jun 7, 2024

Thank you @Jean-Beru.

@fabpot fabpot merged commit 678fede into symfony:6.4 Jun 7, 2024
8 of 10 checks passed
This was referenced Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants