Skip to content

[Validator] Add errorPath to Unique constraint #57436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

norkunas
Copy link
Contributor

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #46182
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Jun 18, 2024
@norkunas norkunas force-pushed the unique-validator-error-path branch 2 times, most recently from 0bf1f18 to aa51f92 Compare June 18, 2024 08:26
@norkunas norkunas force-pushed the unique-validator-error-path branch from aa51f92 to c8051ce Compare June 18, 2024 09:23
@fabpot
Copy link
Member

fabpot commented Jun 19, 2024

Thank you @norkunas.

@fabpot fabpot merged commit 46b624f into symfony:7.2 Jun 19, 2024
7 of 10 checks passed
@norkunas norkunas deleted the unique-validator-error-path branch June 19, 2024 06:58
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Aug 26, 2024
…2200)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[Validator] Add errorPath to Unique constraint

Document symfony/symfony#57436
and closes #19976

Commits
-------

23838fd [Validator] Add errorPath to Unique constraint
@fabpot fabpot mentioned this pull request Oct 27, 2024
GSadee added a commit to Sylius/Sylius that referenced this pull request Jan 9, 2025
| Q               | A
|-----------------|-----
| Branch?         | 2.0
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | n/a
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->

symfony/symfony#57436 was merged and released,
we can now revert our skipped test


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Tests**
- Updated test configuration to remove Symfony version-specific test
skipping
- Ensured test for catalog promotion scope validation now runs
unconditionally

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Validator] Unique constraint error path
4 participants