Skip to content

[AssetMapper][FrameworkBundle] Revert "feature #57073 Do not require http_client service (ruudk)" #57534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[AssetMapper][FrameworkBundle] Revert "feature #57073 Do not require http_client service (ruudk)" #57534

wants to merge 1 commit into from

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues -
License MIT

Reverts #57073, which is replaced by #57533 /cc @ruudk @xabbuh

@nicolas-grekas
Revert "feature symfony#57073 [AssetMapper][FrameworkBundle] Do not r…
efa3e7f 
…equire `http_client` service (ruudk)"

This reverts commit 66b57c9, reversing
changes made to 3bdbb07.
@carsonbot carsonbot added this to the 7.2 milestone Jun 26, 2024
@carsonbot carsonbot changed the title Revert "feature #57073 [AssetMapper][FrameworkBundle] Do not require http_client service (ruudk)" [AssetMapper][FrameworkBundle] Revert "feature #57073 Do not require http_client service (ruudk)" Jun 26, 2024
@nicolas-grekas
Copy link
Member Author

Let's keep as is, this might make it easier to use the component standalone afterall.

@nicolas-grekas nicolas-grekas deleted the revert-am-hc branch June 28, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
AssetMapper Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot