Skip to content

[SecurityBundle] Remove unused memory users’ name attribute from the XSD #57578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix cdb8354
License MIT

#57520 has been reverted because

[The] change […] risks that someone receives errors on the next patch release if their XML config still makes use of the now removed attribute.

But nobody could use it since v6.0: as #41613 removed the BC layer, the config would crash.

Keeping name in the XSD for 6.4, 7.0 and 7.1 branches means people using these versions would have their IDE suggesting an attribute which would make their app crash.

@nicolas-grekas
Copy link
Member

Thank you @MatTheCat.

@nicolas-grekas nicolas-grekas merged commit bc9964b into symfony:6.4 Jun 28, 2024
9 of 10 checks passed
@MatTheCat MatTheCat deleted the xsd_in-memory_name branch June 28, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants