From ee7ffbd4a429e7cab9a9181f5007537539cef781 Mon Sep 17 00:00:00 2001 From: Christian Flothmann Date: Sat, 6 Jul 2024 20:13:11 +0200 Subject: [PATCH] do not use uniqid() in tests updates the remaining tests that were not covered by #57665 --- .../Tests/Factory/HttpFoundationFactoryTest.php | 6 +++--- src/Symfony/Component/Filesystem/Tests/FilesystemTest.php | 2 +- .../Bridge/Redis/Tests/Transport/ConnectionTest.php | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php b/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php index 7456ea34b5e71..ed71b36fe6bea 100644 --- a/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php +++ b/src/Symfony/Bridge/PsrHttpMessage/Tests/Factory/HttpFoundationFactoryTest.php @@ -172,15 +172,15 @@ public function testCreateUploadedFile() $symfonyUploadedFile = $this->callCreateUploadedFile($uploadedFile); $size = $symfonyUploadedFile->getSize(); - $uniqid = uniqid(); - $symfonyUploadedFile->move($this->tmpDir, $uniqid); + $filename = 'upload'; + $symfonyUploadedFile->move($this->tmpDir, $filename); $this->assertEquals($uploadedFile->getSize(), $size); $this->assertEquals(\UPLOAD_ERR_OK, $symfonyUploadedFile->getError()); $this->assertEquals('myfile.txt', $symfonyUploadedFile->getClientOriginalName()); $this->assertEquals('txt', $symfonyUploadedFile->getClientOriginalExtension()); $this->assertEquals('text/plain', $symfonyUploadedFile->getClientMimeType()); - $this->assertEquals('An uploaded file.', file_get_contents($this->tmpDir.'/'.$uniqid)); + $this->assertEquals('An uploaded file.', file_get_contents($this->tmpDir.'/'.$filename)); } public function testCreateUploadedFileWithError() diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php index 57939545c5313..d58b88a7b3186 100644 --- a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php +++ b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php @@ -863,7 +863,7 @@ public function testRenameOverwritesTheTargetIfItAlreadyExists() public function testRenameThrowsExceptionOnError() { $this->expectException(IOException::class); - $file = $this->workspace.\DIRECTORY_SEPARATOR.uniqid('fs_test_', true); + $file = $this->workspace.\DIRECTORY_SEPARATOR.'does-not-exist'; $newPath = $this->workspace.\DIRECTORY_SEPARATOR.'new_file'; $this->filesystem->rename($file, $newPath); diff --git a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php index 2cc11164da9b4..01262ab28df9e 100644 --- a/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php +++ b/src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php @@ -413,7 +413,7 @@ public function testInvalidSentinelMasterName() } $master = getenv('MESSENGER_REDIS_DSN'); - $uid = uniqid('sentinel_'); + $uid = random_int(1, PHP_INT_MAX); $exp = explode('://', $master, 2)[1]; $this->expectException(\InvalidArgumentException::class);