[ExpressionLanguage] Allow passing any iterable as $providers list
#57685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
reviewed
Jul 9, 2024
Comment on lines
146
to
148
| $this->assertEquals('foo', $expressionLanguage->evaluate('identity("foo")')); | ||
| $this->assertEquals('"foo"', $expressionLanguage->compile('identity("foo")')); | ||
| $this->assertEquals('FOO', $expressionLanguage->evaluate('strtoupper("foo")')); |
There was a problem hiding this comment.
while on it, can we use assertSame here and in other places of the test class?
There was a problem hiding this comment.
I didn't have time to respond yesterday, but I see it's been taken care of in #57693
nicolas-grekas
approved these changes
Jul 9, 2024
xabbuh
approved these changes
Jul 9, 2024
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would make it possible to register expression function providers using tagged iterators: