Skip to content

[Serializer] Remove redundant @internal tags from traceable classes #58013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Aug 14, 2024

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

As requested by #56823 (comment)

@chalasr
Copy link
Member

chalasr commented Aug 14, 2024

Thank you @HypeMC.

@chalasr chalasr merged commit c7f46c5 into symfony:6.4 Aug 14, 2024
5 of 10 checks passed
@HypeMC HypeMC deleted the remove-redundant-internal branch August 14, 2024 21:54
@@ -21,7 +21,7 @@
/**
* @author Mathias Arlaud <mathias.arlaud@gmail.com>
*
* @internal
* @final
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @final
* @final since 6.4

?

Do we plan to make it real final?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants