Skip to content

[HttpKernel] pass CSV escape characters explicitly #58266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 15, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Not passing the $escape parameter is deprecated since PHP 8.4 as the default value will change in the future.

@carsonbot carsonbot added this to the 5.4 milestone Sep 15, 2024
@xabbuh xabbuh force-pushed the php-8.4-csv-escape branch 3 times, most recently from 2f7d831 to 73aa619 Compare September 15, 2024 07:13
@xabbuh xabbuh changed the title [HttpKernel] pass CSV escape characters explicitly [HttpKernel][Translation][Validator] pass CSV escape characters explicitly Sep 15, 2024
@carsonbot carsonbot changed the title [HttpKernel][Translation][Validator] pass CSV escape characters explicitly [HttpKernel] pass CSV escape characters explicitly Sep 15, 2024
Not passing the $escape parameter is deprecated since PHP 8.4 as the
default value will change in the future.
@xabbuh xabbuh merged commit e104cd2 into symfony:5.4 Sep 16, 2024
9 of 12 checks passed
@xabbuh xabbuh deleted the php-8.4-csv-escape branch September 16, 2024 05:54
This was referenced Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants