Skip to content

[HttpClient] Add crypto_method to scoped client options #58343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Sep 21, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

While working on something else I've noticed that the crypto_method option wasn't added for scoped clients in #50274. I'm not sure if this was intentional or not, but as far as I can tell, there's no reason for the option to not be there, so I'm guessing it was an oversight.

@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit fa06f56 into symfony:6.4 Sep 28, 2024
9 of 10 checks passed
@HypeMC HypeMC deleted the add-crypto-method-to-scoped-clients branch September 28, 2024 10:06
This was referenced Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants