Skip to content

[Serializer] Readd AdvancedNameConverterInterface to MetadataAwareNameConverter #58368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

aurimasrim
Copy link
Contributor

[Serializer] Readd AdvancedNameConverterInterface to MetadataAwareNameConverter

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58294
License MIT

Fixes BC break introduced in a minor version 7.1

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh
Copy link
Member

xabbuh commented Sep 24, 2024

The change looks good to me. I shouldn't have changed that in #54531.

@nicolas-grekas
Copy link
Member

Thank you @aurimasrim.

@nicolas-grekas nicolas-grekas merged commit 3c7124e into symfony:7.1 Sep 24, 2024
9 of 10 checks passed
@aurimasrim aurimasrim deleted the fix_58294 branch September 24, 2024 11:07
@fabpot fabpot mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants