Skip to content

[FrameworkBundle] Simplify the configuration class #58450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Spotted while documenting #58161.

@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2024

This of is not exactly the same as the empty string would become an array with one element.

@stof
Copy link
Member

stof commented Oct 4, 2024

@javiereguiluz only trusted_hosts and trusted_headers are impacted by that remark (as they don't perform a simple wrapping in array. Other changes in the PR are good.

@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2024

@stof is right. I was reading the changes in my phone and didn’t realise that there were more changes.

@javiereguiluz
Copy link
Member Author

Thanks for the review. I reverted the wrong changes.

@nicolas-grekas
Copy link
Member

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit fddd33e into symfony:7.2 Oct 4, 2024
9 of 10 checks passed
@javiereguiluz javiereguiluz deleted the fwb_config branch October 4, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants