[FrameworkBundle] Add support for setting headers to TemplateController::__invoke()
#58464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 4, 2024
|
Maybe we could add a test using Reflection to compare the signature of both methods, to avoid such mistake in the future when adding new features in it (as the test would force you to add the new argument in the other method) |
a512c2f to
90cb6b9
Compare
@stof Good idea, done https://github.com/symfony/symfony/compare/a512c2fb64e896814844fb5e6344358f087043f6..90cb6b958a1dcadb80a5c08672e43a94d33ef99d |
fabpot
approved these changes
Oct 6, 2024
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #54678
Looks like I forgot to add it to the
__invoke()method, 🤦