Skip to content

[FrameworkBundle] Fix NullStore registration #58518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Oct 10, 2024

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Follow up to #58109 and #58445, cc @xabbuh

I'm not sure if there's a way to get the XML config to work with the current schema as null is not interpreted as a string:

<framework:resource name="garply">null</framework:resource>

@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 52a280e into symfony:7.2 Oct 23, 2024
5 of 10 checks passed
@HypeMC HypeMC deleted the fix-registering-nullstore branch October 23, 2024 08:05
nicolas-grekas added a commit that referenced this pull request Oct 23, 2024
…xabbuh)

This PR was merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] fix null store handling in XML configs

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | see #58518
| License       | MIT

Commits
-------

b50ecb2 fix null store handling in XML configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants