[Validator] [Choice] Fix callback option if not array returned #58615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Oct 22, 2024
src/Symfony/Component/Validator/Constraints/ChoiceValidator.php
Outdated
Show resolved
Hide resolved
xabbuh
reviewed
Oct 22, 2024
xabbuh
approved these changes
Oct 22, 2024
20e6cc9 to
02d2769
Compare
|
Thank you @symfonyaml. |
This was referenced Oct 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using the Choice validator
callbackoption, and the callback method provided does not return an array or iterable, it causes a PHP error.See all details and how to reproduce it in the issue #58610
Solution
In this PR
NOTE : This PR replaces the old one (I messed up with the branch rebase)