From e90e624d361c1364e48253d37cce9062d4498875 Mon Sep 17 00:00:00 2001 From: Carl Julian Sauter Date: Thu, 14 Nov 2024 13:13:49 +0100 Subject: [PATCH 1/3] Added body_size_limit option --- src/Symfony/Component/HttpClient/AmpHttpClient.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Symfony/Component/HttpClient/AmpHttpClient.php b/src/Symfony/Component/HttpClient/AmpHttpClient.php index 5200b424bad02..cd27709ff3dd2 100644 --- a/src/Symfony/Component/HttpClient/AmpHttpClient.php +++ b/src/Symfony/Component/HttpClient/AmpHttpClient.php @@ -52,6 +52,7 @@ final class AmpHttpClient implements HttpClientInterface, LoggerAwareInterface, public const OPTIONS_DEFAULTS = HttpClientInterface::OPTIONS_DEFAULTS + [ 'crypto_method' => \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT, + 'body_size_limit' => null ]; private array $defaultOptions = self::OPTIONS_DEFAULTS; @@ -134,6 +135,10 @@ public function request(string $method, string $url, array $options = []): Respo }); } + if ($options['body_size_limit']) { + $request->setBodySizeLimit($options['body_size_limit']); + } + foreach ($options['headers'] as $v) { $h = explode(': ', $v, 2); $request->addHeader($h[0], $h[1]); From 215e2e14770edd0ee03338790a6444e332640023 Mon Sep 17 00:00:00 2001 From: Carl Julian Sauter Date: Thu, 14 Nov 2024 13:26:34 +0100 Subject: [PATCH 2/3] Added trailing comma --- src/Symfony/Component/HttpClient/AmpHttpClient.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Symfony/Component/HttpClient/AmpHttpClient.php b/src/Symfony/Component/HttpClient/AmpHttpClient.php index cd27709ff3dd2..0ce63a9fe6ec0 100644 --- a/src/Symfony/Component/HttpClient/AmpHttpClient.php +++ b/src/Symfony/Component/HttpClient/AmpHttpClient.php @@ -52,7 +52,7 @@ final class AmpHttpClient implements HttpClientInterface, LoggerAwareInterface, public const OPTIONS_DEFAULTS = HttpClientInterface::OPTIONS_DEFAULTS + [ 'crypto_method' => \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT, - 'body_size_limit' => null + 'body_size_limit' => null, ]; private array $defaultOptions = self::OPTIONS_DEFAULTS; From bde3a63b74b113f12906ab0ed2438ff3af18afa7 Mon Sep 17 00:00:00 2001 From: Carl Julian Sauter Date: Thu, 14 Nov 2024 15:26:36 +0100 Subject: [PATCH 3/3] Completely remove body size limit --- src/Symfony/Component/HttpClient/AmpHttpClient.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/Symfony/Component/HttpClient/AmpHttpClient.php b/src/Symfony/Component/HttpClient/AmpHttpClient.php index 0ce63a9fe6ec0..4c73fbaf3db24 100644 --- a/src/Symfony/Component/HttpClient/AmpHttpClient.php +++ b/src/Symfony/Component/HttpClient/AmpHttpClient.php @@ -52,7 +52,6 @@ final class AmpHttpClient implements HttpClientInterface, LoggerAwareInterface, public const OPTIONS_DEFAULTS = HttpClientInterface::OPTIONS_DEFAULTS + [ 'crypto_method' => \STREAM_CRYPTO_METHOD_TLSv1_2_CLIENT, - 'body_size_limit' => null, ]; private array $defaultOptions = self::OPTIONS_DEFAULTS; @@ -126,6 +125,7 @@ public function request(string $method, string $url, array $options = []): Respo } $request = new Request(implode('', $url), $method); + $request->setBodySizeLimit(0); if ($options['http_version']) { $request->setProtocolVersions(match ((float) $options['http_version']) { @@ -135,10 +135,6 @@ public function request(string $method, string $url, array $options = []): Respo }); } - if ($options['body_size_limit']) { - $request->setBodySizeLimit($options['body_size_limit']); - } - foreach ($options['headers'] as $v) { $h = explode(': ', $v, 2); $request->addHeader($h[0], $h[1]);