Skip to content

Proofread UPGRADE guide #58899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2024
Merged

Proofread UPGRADE guide #58899

merged 1 commit into from
Nov 27, 2024

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Nov 16, 2024

Q A
Branch? 7.2
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

@wouterj wouterj requested a review from dunglas as a code owner November 16, 2024 14:50
@carsonbot carsonbot added this to the 7.2 milestone Nov 16, 2024
maxbeckers
maxbeckers approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@maxbeckers maxbeckers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that :)

fabpot
fabpot requested changes Nov 18, 2024
View reviewed changes
MrYamous
MrYamous reviewed Nov 18, 2024
View reviewed changes
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@nicolas-grekas nicolas-grekas modified the milestones: 7.3, 7.2 Nov 20, 2024
@xabbuh xabbuh added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Nov 20, 2024
@wouterj wouterj changed the base branch from 7.3 to 7.2 November 25, 2024 15:21
@fabpot
Copy link
Member

fabpot commented Nov 27, 2024

Thank you @wouterj.

@fabpot fabpot merged commit 8be876c into symfony:7.2 Nov 27, 2024
5 of 11 checks passed
@OskarStark
Copy link
Contributor

Thank you very much @wouterj that is very key to be able to upgrade smoothly. Thanks for your patience 🥰

@wouterj wouterj deleted the upgrade-72 branch November 27, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@MrYamous MrYamous MrYamous left review comments

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
9 participants
@wouterj @fabpot @OskarStark @javiereguiluz @xabbuh @maxbeckers @MrYamous @nicolas-grekas @carsonbot