[HttpClient] Fix option "resolve" with IPv6 addresses #58915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 18, 2024
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | - |
| License | MIT |
7d41709 to
5c757be
Compare
nicolas-grekas
commented
Nov 19, 2024
| @@ -79,6 +79,9 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| if (str_starts_with($options['bindto'], 'host!')) { | |||
| $options['bindto'] = substr($options['bindto'], 5); | |||
| } | |||
| if ((\PHP_VERSION_ID < 80223 || 80300 <= \PHP_VERSION_ID && 80311 < \PHP_VERSION_ID) && '\\' === \DIRECTORY_SEPARATOR && '[' === $options['bindto'][0]) { | |||
| $options['bindto'] = preg_replace('{^\[[^\]]++\]}', '[$0]', $options['bindto']); | |||
There was a problem hiding this comment.
This fixes the failure on Windows. I verified that on Windows, before PHP 8.2.23, bindto needs double brackets for binding to IPv6 addresses ([[::1]]:0).
I looked at the changelog of PHP 8.2.23 and the only PR that looks related is
php/php-src#15068
I also compiled PHP 8.2.22 on my Ubuntu and the issue doesn't show up, while it does on Windows with the same version.
5c757be to
9af9a9d
Compare
9af9a9d to
954fc1c
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2024
…nt 5 (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [HttpClient] resolve IPv6 addresses with amphp/http-client 5 | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT following the changes from #58915 Commits ------- 3a732af resolve IPv6 addresses with amphp/http-client 5
This was referenced Nov 27, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.