From 1f31a5e4382675bc7fb775a5e74de38cfdd7eaff Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Tue, 19 Nov 2024 11:30:14 +0100 Subject: [PATCH] [HttpClient] Fix empty hosts in option "resolve" --- src/Symfony/Component/HttpClient/HttpClientTrait.php | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Component/HttpClient/HttpClientTrait.php b/src/Symfony/Component/HttpClient/HttpClientTrait.php index 2d2fa7dd9f06f..f116458588f10 100644 --- a/src/Symfony/Component/HttpClient/HttpClientTrait.php +++ b/src/Symfony/Component/HttpClient/HttpClientTrait.php @@ -198,9 +198,8 @@ private static function mergeDefaultOptions(array $options, array $defaultOption $options['resolve'] = []; foreach ($resolve as $k => $v) { if ('' === $v = (string) $v) { - throw new InvalidArgumentException(sprintf('Option "resolve" for host "%s" cannot be empty.', $k)); - } - if ('[' === $v[0] && ']' === substr($v, -1) && str_contains($v, ':')) { + $v = null; + } elseif ('[' === $v[0] && ']' === substr($v, -1) && str_contains($v, ':')) { $v = substr($v, 1, -1); } @@ -228,9 +227,8 @@ private static function mergeDefaultOptions(array $options, array $defaultOption if ($resolve = $defaultOptions['resolve'] ?? false) { foreach ($resolve as $k => $v) { if ('' === $v = (string) $v) { - throw new InvalidArgumentException(sprintf('Option "resolve" for host "%s" cannot be empty.', $k)); - } - if ('[' === $v[0] && ']' === substr($v, -1) && str_contains($v, ':')) { + $v = null; + } elseif ('[' === $v[0] && ']' === substr($v, -1) && str_contains($v, ':')) { $v = substr($v, 1, -1); }