Skip to content

chore: fix some typos #58972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2024
Merged

chore: fix some typos #58972

merged 1 commit into from
Nov 23, 2024

Conversation

wanxiangchwng
Copy link
Contributor

@wanxiangchwng wanxiangchwng commented Nov 23, 2024

Q A
Branch? 7.3 for features
Bug fix? yes/no
New feature? yes/no
Deprecations? yes/no
Issues Fix #...
License MIT

Signed-off-by: wanxiangchwng <cui.shuang@foxmail.com>
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.3 for features / 5.4, 6.4, 7.1, and 7.2 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Nov 23, 2024

Thank you @wanxiangchwng.

@fabpot fabpot merged commit 5a90414 into symfony:7.3 Nov 23, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants