Skip to content

[AssetMapper] use constants in MappedAssetFactoryTest #59057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

[AssetMapper] use constants in MappedAssetFactoryTest #59057

merged 1 commit into from
Jan 7, 2025

Conversation

alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Dec 1, 2024 •
edited
Loading

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues no
License MIT

This avoids repeating __DIR__ in several places.

Follow-up of:

@carsonbot carsonbot added this to the 7.3 milestone Dec 1, 2024
@alexislefebvre alexislefebvre changed the title feat: use constants in MappedAssetFactoryTest [AssetMapper] feat: use constants in MappedAssetFactoryTest Dec 1, 2024
@alexislefebvre alexislefebvre force-pushed the feat-use-constants-in-MappedAssetFactoryTest branch from 5b5beb7 to cdb3080 Compare January 1, 2025 15:51
@carsonbot carsonbot changed the title [AssetMapper] feat: use constants in MappedAssetFactoryTest feat: use constants in MappedAssetFactoryTest Jan 1, 2025
@carsonbot carsonbot changed the title feat: use constants in MappedAssetFactoryTest [AssetMapper] feat: use constants in MappedAssetFactoryTest Jan 7, 2025
@nicolas-grekas nicolas-grekas changed the title [AssetMapper] feat: use constants in MappedAssetFactoryTest [AssetMapper] use constants in MappedAssetFactoryTest Jan 7, 2025
@nicolas-grekas
Copy link
Member

Thank you @alexislefebvre.

@nicolas-grekas nicolas-grekas merged commit 737316d into symfony:7.3 Jan 7, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
AssetMapper Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
4 participants
@alexislefebvre @nicolas-grekas @OskarStark @carsonbot